-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-string keys when rewriting assertDictContainsSubset #55
Conversation
I guess |
Thanks @verhovsky! My 2 cents: I think dropping Python 2 is fine, and then we always use the Python 3 syntax ( If not, not sure we need a flag, we might just use the version of the Python we are running ( |
If someone doesn't realize their I also dropped Python 3.5 which is unsupported since 2020-09, I hope that's fine. |
LGTM! This also warrants a changelog entry. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Created follow up in #73. Sorry @verhovsky for the long delay here. |
and also update supported Python versions in tox.ini.
#54